Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of ASGIApp (#2057) #2058

Closed
wants to merge 1 commit into from
Closed

Fix typing of ASGIApp (#2057) #2058

wants to merge 1 commit into from

Conversation

ods
Copy link

@ods ods commented Mar 2, 2023

According to ASGI spec both scope and event message must be dictionaries, not an arbitrary mutable mapping.

@ods
Fix typing of ASGIApp (encode#2057)
d133124 
According to ASGI spec both scope and event message must be dictionaries, not an arbitrary mutable mapping.
@Kludex
Copy link
Member

Kludex commented Mar 2, 2023

Let's discuss it first, please: #2059.

@Kludex Kludex closed this Mar 2, 2023
@ods
Copy link
Author

ods commented Mar 2, 2023

Let's discuss it first, please: #2059.

Sure, I've created discussion first. But it didn't work: #2040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ods @Kludex